Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e troubleshooting #448

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Improve e2e troubleshooting #448

merged 3 commits into from
Dec 16, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Nov 6, 2024

Improve / fix some issues with e2e tests:

  • Add more logs; print some useful information such as when cluster is still up
  • Improve readiness (e.g: had agents pods crashing)
  • Use more up to date templates for loki and kafka (similar to what we have in docs repo)
  • Add doc

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.58%. Comparing base (70003f2) to head (d281422).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   29.68%   30.58%   +0.90%     
==========================================
  Files          51       48       -3     
  Lines        4915     4626     -289     
==========================================
- Hits         1459     1415      -44     
+ Misses       3350     3106     -244     
+ Partials      106      105       -1     
Flag Coverage Δ
unittests 30.58% <ø> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@jotak jotak requested a review from msherif1234 November 18, 2024 10:19
Improve / fix some issues with e2e tests:
- Add more logs; print some useful information such as when cluster is
  still up
- Improve readiness (e.g: had agents pods crashing)
- Use more up to date templates for loki and kafka (similar to what we
  have in docs repo)
Tagging e2e is not necessary and has some undesired side effect such as
excluding these e2e source files from building/linting, which can
invisibilise some problems
@jotak jotak added no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval labels Dec 12, 2024
@msherif1234
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 889f4f1 into netobserv:main Dec 16, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants