Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ovn model utilities #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add ovn model utilities #481

wants to merge 1 commit into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Dec 10, 2024

No description provided.

@jotak jotak requested a review from msherif1234 December 10, 2024 17:13
@msherif1234
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 29.28%. Comparing base (70003f2) to head (8551a01).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/utils/network_events.go 0.00% 45 Missing ⚠️
pkg/agent/agent.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   29.68%   29.28%   -0.41%     
==========================================
  Files          51       52       +1     
  Lines        4915     4962      +47     
==========================================
- Hits         1459     1453       -6     
- Misses       3350     3402      +52     
- Partials      106      107       +1     
Flag Coverage Δ
unittests 29.28% <0.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/agent/agent.go 33.58% <0.00%> (-0.17%) ⬇️
pkg/utils/network_events.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msherif1234
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants