Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memset dns id to 0 #494

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Memset dns id to 0 #494

merged 1 commit into from
Dec 18, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Dec 18, 2024

That's a regression following the map split PR, which removed packed attributes; now that map keys aren't packed anymore, it becomes critical to initialize them: failing to do so results in having many map misses on lookup due to pad fields having random values.

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 18, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:5443cf8

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=5443cf8 make set-agent-image

@jotak
Copy link
Member Author

jotak commented Dec 18, 2024

@jotak jotak requested a review from msherif1234 December 18, 2024 13:38
@msherif1234
Copy link
Contributor

pls add in the description this was a regression caused by #469 for better tracking, I checked other hooks they seem fine and initialize their key.
/lgtm

@jotak
Copy link
Member Author

jotak commented Dec 18, 2024

/approve

Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit bb70b5a into netobserv:main Dec 18, 2024
6 of 8 checks passed
@jotak jotak mentioned this pull request Dec 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants