Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/vladimirvivien/gexe from 0.3.0 to 0.4.0 #111

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps github.com/vladimirvivien/gexe from 0.3.0 to 0.4.0.

Release notes

Sourced from github.com/vladimirvivien/gexe's releases.

v0.4.0

This release did not introduce new functionalities, but rather implemented fixes and improvements that have been lingering for a while.

Release overview

  • Better support for setting Stdout/Stderr when working with exec package
  • Fixed out-of-order bug that would make exec.Proc.Resut() and exec.Proc.Out() calls return empty result from the process
  • Additional checked error propagation in API call chain in several packages
  • Enhancements to exec.CommandBuilder to fix piped commands constructs
  • Ability to set stdout/stderr for batch commands with exec.CommandBuilder
  • Further standardization of function and method signatures for packages http and fs
  • Enhancements to internal tests

API changes

Package exec changes

Previously, method Proc.Out() in package exec would automatically start a defined process (if not started) then return output of the process as a combined Stdout/Stderr streams. This behavior has been simplified:

  • The API user is responsible for starting the process prior to calling proc.Out()
  • Method Proc.Out() only returns the combined output stream if no other streams were set for the process
  • If other streams were set, an API user is responsible for accessing the configured output stream for process result.

Method proc.Result() still returns the combined output stream as string (by calling proc.Out()) if an output stream was not explicitly set.

See example here

Package vars changes

This release introduces subtle changes to how methods vars.Variables.Envs and vars.Variables.Vars work. Before this release, these methods accepted a single string with key=value pairs separated by spaces:

gexe.Vars(`msg0=hello msg1=world`).

In this release, however, the signatures for both Envs and Vars have been updated as variadic methods that accept zero or more string values. Each string parameter is not expected to provide a single key=value pair:

gexe.Envs(`GOOS="linux"`, `GOARCH=arm64`).Run(`go build .`)

Note that this change provides the flexibility of specifying variables with quoted values and supports spaces in the values.

Related PRs

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/vladimirvivien/gexe](https://github.com/vladimirvivien/gexe) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/vladimirvivien/gexe/releases)
- [Commits](vladimirvivien/gexe@v0.3.0...v0.4.0)

---
updated-dependencies:
- dependency-name: github.com/vladimirvivien/gexe
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 4, 2024
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 4, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.00%. Comparing base (0398f3b) to head (b9a7f11).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   25.08%   26.00%   +0.92%     
==========================================
  Files           8        8              
  Lines        1148     1315     +167     
==========================================
+ Hits          288      342      +54     
- Misses        839      952     +113     
  Partials       21       21              
Flag Coverage Δ
unittests 26.00% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 25, 2024

Superseded by #126.

@dependabot dependabot bot closed this Nov 25, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/vladimirvivien/gexe-0.4.0 branch November 25, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs-ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants