NETOBSERV-1909 filter regexes #121
Conversation
scripts/functions.sh
Outdated
| rules=() | ||
| for regex in $(echo $2 | tr "," "\n") | ||
| do | ||
| keyValue=(${regex//"~"/ }) |
There was a problem hiding this comment.
☝️ We may implement more splitter if needed here to manage other rules
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 25.07% 25.07%
=======================================
Files 9 9
Lines 1368 1368
=======================================
Hits 343 343
Misses 1004 1004
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -187,6 +188,7 @@ function common_usage { | |||
| echo " --icmp_code: filter ICMP code (default: n/a)" | |||
| echo " --peer_ip: filter peer IP (default: n/a)" | |||
| echo " --drops: filter flows with only dropped packets (default: false)" | |||
| echo " --regexes: filter flows using regex (default: n/a)" | |||
There was a problem hiding this comment.
I feel like this deserves more explanation and perhaps a simple example, no? What the regex will be running against? The json representation of the flow? (I know it's not but the user may not know) From code it looks like user has to provide keys and values, we can mention that.
Also, nit: in the description I'd use the full wording "regular expressions" rather than "regex".
There was a problem hiding this comment.
Every filter need examples so I created a followup: https://issues.redhat.com/browse/NETOBSERV-2011
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Implement FLP regexes filters in CLI. Example:
Dependencies
netobserv/flowlogs-pipeline#740
=> will need to update eBPF agent since CLI rely on direct+flp mode
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.