NETOBSERV-2009: network events to string

[jotak]

I've only been able to test through unit tests, not in live (I have issues deploying the CLI which I must investigate )

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:95f3c17

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=95f3c17 make commands

or download the updated commands.

[codecov]

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.16%. Comparing base (245f6a0) to head (5330730).

Files with missing lines	Patch %	Lines
cmd/map_format.go	84.84%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   22.66%   24.16%   +1.49%     
==========================================
  Files          10       10              
  Lines        1337     1370      +33     
==========================================
+ Hits          303      331      +28     
- Misses       1015     1019       +4     
- Partials       19       20       +1     

Flag	Coverage Δ
unittests	24.16% <84.84%> (+1.49%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cmd/map_format.go	27.42% <84.84%> (+4.29%)	⬆️

[msherif1234]

/lgtm
as discussed offline will be good to share this code between cli and console

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-2009 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

I've only been able to test through unit tests, not in live (I have issues deploying the CLI which I must investigate )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[memodi]

@jotak @msherif1234 I still don't see network events with the CLI image in this PR:

for same flows I am able to see network events in console:

@msherif1234 - does running cli as CLI ./oc-netobserv flows --enable_network_events sets collector in privileged mode and enable NetworkEvents feature?

[jotak]

@memodi it's not --enable_network_events but --enable_network_events=true (I got trapped with the same!)
Anyway even with that currently I still don't see events ... :-/
trying to figure out why

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment