NETOBSERV-1471 capture using gRPC #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinsonneau
changed the title
jpinsonneau
commented
Mar 6, 2024
| oc run \ | ||
| -n netobserv-cli \ | ||
| collector \ | ||
| --image=quay.io/jpinsonn/network-observability-cli:dev \ |
There was a problem hiding this comment.
This image will be updated once images will be generated by github actions
10 tasks
jpinsonneau
commented
Mar 12, 2024
jpinsonneau
force-pushed
the
1471
branch
2 times, most recently
from
08ca611 to
7e78123
Compare
jpinsonneau
commented
Mar 15, 2024
|
Merging this to work on #4 Feel free to open PRs if you have any issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements gRPC connection from netobserv/flowlogs-pipeline#621 & netobserv/netobserv-ebpf-agent#291
Since the server can't run using
port-forward, I took the opportunity to useoc runcommand instead. The pod is now running inside the cluster and only the terminal view is exposed outside.Based on #2
TODO: update eBPF agent and image URL when ready before merging