-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1803: Allow flow filtering for L4 protocols using two ports #84
NETOBSERV-1803: Allow flow filtering for L4 protocols using two ports #84
Conversation
@msherif1234: This pull request references NETOBSERV-1803 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
e47d69e
to
8225e16
Compare
/ok-to-test |
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=60550b9 make commands |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 25.10% 25.10%
=======================================
Files 8 8
Lines 1147 1147
=======================================
Hits 288 288
Misses 838 838
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. |
@msherif1234 could you please rebase ? |
8225e16
to
c5c8b67
Compare
Signed-off-by: Mohamed Mahmoud <[email protected]>
c5c8b67
to
fec871a
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Allow filtering TCP/UDP/SCTP using two ports syntax like "90,100" to filter either on port 90 or 100
Dependencies
netobserv/netobserv-ebpf-agent#389
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.