NETOBSERV-2314 Export overview / topology freeze browser

[jpinsonneau]

Description

Update html-to-image dependency to improve export perfs.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[jotak]

/lgtm
html-to-image mentions indeed 2 performance improvements in 1.11.12 https://github.com/bubkoo/html-to-image/releases/tag/v1.11.12

[jotak]

@jpinsonneau could you run make frontend ? CI complains about something no clean in lock file

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpinsonneau]

@jpinsonneau could you run make frontend ? CI complains about something no clean in lock file

Sure, done ✔️
The lock file is now fixed

[Amoghrd]

/ok-to-test

[jotak]

/lgtm

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:427502c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=427502c make set-plugin-image

[Amoghrd]

@jpinsonneau Export button does not seem to work on Overview and Topology pages on firefox. It works fine on chrome

[jpinsonneau]

@jpinsonneau Export button does not seem to work on Overview and Topology pages on firefox. It works fine on chrome

Thanks for pointing that ! Here is the issue: bubkoo/html-to-image#532

I have opened a PR to fix it. Let's see if it's merged and released quickly or not.
Else we can point my repo instead.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jpinsonneau]

I don't get any feedback upstream so I created my own package:
https://www.npmjs.com/package/@jpinsonneau/html-to-image
78d70e8

[jotak]

ah, the upstream PR finally is approved (not merged yet)

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:9ca2a02

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9ca2a02 make set-plugin-image

[Amoghrd]

/label qe-approved

[openshift-ci]

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/plugin-cypress	55a4745	link	true	/test plugin-cypress
ci/prow/qe-e2e-console-tests	55a4745	link	false	/test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.