Add packet drop filtering API

Signed-off-by: Mohamed Mahmoud <[email protected]>
netobserv · Oct 1, 2024 · 7edaf2c · 7edaf2c
1 parent 0de6d49
commit 7edaf2c
Show file tree

Hide file tree

Showing 9 changed files with 52 additions and 0 deletions.
diff --git a/apis/flowcollector/v1beta1/flowcollector_types.go b/apis/flowcollector/v1beta1/flowcollector_types.go
@@ -249,6 +249,10 @@ type EBPFFlowFilter struct {
 	// ICMPCode defines the ICMP code to filter flows by.
 	// +optional
 	ICMPCode *int `json:"icmpCode,omitempty"`
+
+	// `pktDrops`, to filter flows with packet drops
+	// +optional
+	PktDrops *bool `json:"pktDrops,omitempty"`
 }
 
 // `FlowCollectorEBPF` defines a FlowCollector that uses eBPF to collect the flows information

diff --git a/apis/flowcollector/v1beta1/zz_generated.conversion.go b/apis/flowcollector/v1beta1/zz_generated.conversion.go
diff --git a/apis/flowcollector/v1beta1/zz_generated.deepcopy.go b/apis/flowcollector/v1beta1/zz_generated.deepcopy.go
diff --git a/apis/flowcollector/v1beta2/flowcollector_types.go b/apis/flowcollector/v1beta2/flowcollector_types.go
@@ -273,6 +273,10 @@ type EBPFFlowFilter struct {
 	// `icmpType`, for ICMP traffic, defines the ICMP type to filter flows by.
 	// +optional
 	ICMPType *int `json:"icmpType,omitempty"`
+
+	// `pktDrops`, to filter flows with packet drops
+	// +optional
+	PktDrops *bool `json:"pktDrops,omitempty"`
 }
 
 // `FlowCollectorEBPF` defines a FlowCollector that uses eBPF to collect the flows information

diff --git a/apis/flowcollector/v1beta2/zz_generated.deepcopy.go b/apis/flowcollector/v1beta2/zz_generated.deepcopy.go
diff --git a/bundle/manifests/flows.netobserv.io_flowcollectors.yaml b/bundle/manifests/flows.netobserv.io_flowcollectors.yaml
@@ -199,6 +199,10 @@ spec:
                               PeerIP defines the IP address to filter flows by.
                               Example: 10.10.10.10
                             type: string
+                          pktDrops:
+                            description: '`pktDrops`, to filter flows with packet
+                              drops'
+                            type: boolean
                           ports:
                             anyOf:
                             - type: integer
@@ -3792,6 +3796,10 @@ spec:
                               `peerIP` defines the IP address to filter flows by.
                               Example: `10.10.10.10`.
                             type: string
+                          pktDrops:
+                            description: '`pktDrops`, to filter flows with packet
+                              drops'
+                            type: boolean
                           ports:
                             anyOf:
                             - type: integer

diff --git a/config/crd/bases/flows.netobserv.io_flowcollectors.yaml b/config/crd/bases/flows.netobserv.io_flowcollectors.yaml
@@ -178,6 +178,9 @@ spec:
                                 PeerIP defines the IP address to filter flows by.
                                 Example: 10.10.10.10
                               type: string
+                            pktDrops:
+                              description: '`pktDrops`, to filter flows with packet drops'
+                              type: boolean
                             ports:
                               anyOf:
                                 - type: integer
@@ -3499,6 +3502,9 @@ spec:
                                 `peerIP` defines the IP address to filter flows by.
                                 Example: `10.10.10.10`.
                               type: string
+                            pktDrops:
+                              description: '`pktDrops`, to filter flows with packet drops'
+                              type: boolean
                             ports:
                               anyOf:
                                 - type: integer

diff --git a/controllers/ebpf/agent_controller.go b/controllers/ebpf/agent_controller.go
@@ -81,6 +81,7 @@ const (
 	envFilterICMPCode             = "FILTER_ICMP_CODE"
 	envFilterPeerIPAddress        = "FILTER_PEER_IP"
 	envFilterTCPFlags             = "FILTER_TCP_FLAGS"
+	envFilterPktDrops             = "FILTER_DROPS"
 	envListSeparator              = ","
 )
 
@@ -573,6 +574,9 @@ func (c *AgentController) configureFlowFilter(filter *flowslatest.EBPFFlowFilter
 		})
 	}
 
+	if filter.PktDrops != nil && *filter.PktDrops {
+		config = append(config, corev1.EnvVar{Name: envFilterPktDrops, Value: "true"})
+	}
 	return config
 }
 

diff --git a/docs/FlowCollector.md b/docs/FlowCollector.md
@@ -496,6 +496,13 @@ To filter two ports, use a "port1,port2" in string format. For example, `ports:
 Example: 10.10.10.10<br/>
         </td>
         <td>false</td>
+      </tr><tr>
+        <td><b>pktDrops</b></td>
+        <td>boolean</td>
+        <td>
+          `pktDrops`, to filter flows with packet drops<br/>
+        </td>
+        <td>false</td>
       </tr><tr>
         <td><b>ports</b></td>
         <td>int or string</td>
@@ -7911,6 +7918,13 @@ To filter two ports, use a "port1,port2" in string format. For example, `ports:
 Example: `10.10.10.10`.<br/>
         </td>
         <td>false</td>
+      </tr><tr>
+        <td><b>pktDrops</b></td>
+        <td>boolean</td>
+        <td>
+          `pktDrops`, to filter flows with packet drops<br/>
+        </td>
+        <td>false</td>
       </tr><tr>
         <td><b>ports</b></td>
         <td>int or string</td>