-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1203 Add field to enable zone #537
Conversation
/hold To prevent conflicts this PR branch is based on #517 so we need to merge that one first. We also needs to merge the FLP PR and upgrade dependency here before merging. |
30c1108
to
515d95c
Compare
515d95c
to
8c61007
Compare
8d5f1b7
to
144289e
Compare
144289e
to
259f5e3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 57.74% 57.83% +0.09%
==========================================
Files 71 71
Lines 9496 9514 +18
==========================================
+ Hits 5483 5502 +19
Misses 3677 3677
+ Partials 336 335 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add a field in flowcollector to enable zones in flows
Dependencies
netobserv/flowlogs-pipeline#575
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.