Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networkevents feature is DevPreview #811

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Networkevents feature is DevPreview #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2d8e48
Add required version for networkevents
jotak Oct 10, 2024
ff4f2b8
dev preview
jotak Oct 10, 2024
e0dc798
mention IMPORTANT and OVN needed
jotak Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions apis/flowcollector/v1beta2/flowcollector_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,15 +167,15 @@ type FlowCollectorIPFIX struct {
// `clusterNetworkOperator` defines the settings related to the OpenShift Cluster Network Operator, when available.
ClusterNetworkOperator ClusterNetworkOperatorConfig `json:"clusterNetworkOperator,omitempty" mapstructure:"-"`

// `ovnKubernetes` defines the settings of the OVN-Kubernetes CNI, when available. This configuration is used when using OVN's IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.
// `ovnKubernetes` defines the settings of the OVN-Kubernetes network plugin, when available. This configuration is used when using OVN's IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.
OVNKubernetes OVNKubernetesConfig `json:"ovnKubernetes,omitempty" mapstructure:"-"`
}

// Agent feature, can be one of:<br>
// - `PacketDrop`, to track packet drops.<br>
// - `DNSTracking`, to track specific information on DNS traffic.<br>
// - `FlowRTT`, to track TCP latency.<br>
// - `NetworkEvents`, to track Network events.<br>
// - `NetworkEvents`, to track Network events [Developer Preview].<br>
// +kubebuilder:validation:Enum:="PacketDrop";"DNSTracking";"FlowRTT";"NetworkEvents"
type AgentFeature string

Expand Down Expand Up @@ -358,8 +358,10 @@ type FlowCollectorEBPF struct {
// If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
// - `DNSTracking`: enable the DNS tracking feature.<br>
// - `FlowRTT`: enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
// - `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
// - `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
// the kernel debug filesystem, so the eBPF pod has to run as privileged.
// It requires using the OVN-Kubernetes network plugin with the Observability feature.
// IMPORTANT: this feature is available as a Developer Preview.<br>
// +optional
Features []AgentFeature `json:"features,omitempty"`

Expand Down Expand Up @@ -1017,7 +1019,7 @@ type ClusterNetworkOperatorConfig struct {
Namespace string `json:"namespace,omitempty"`
}

// `OVNKubernetesConfig` defines the desired configuration related to the OVN-Kubernetes network provider, when Cluster Network Operator isn't installed.
// `OVNKubernetesConfig` defines the desired configuration related to the OVN-Kubernetes network plugin, when Cluster Network Operator isn't installed.
type OVNKubernetesConfig struct {
// Important: Run "make generate" to regenerate code after modifying this file

Expand Down
10 changes: 6 additions & 4 deletions bundle/manifests/flows.netobserv.io_flowcollectors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3729,15 +3729,17 @@ spec:
If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
- `DNSTracking`: enable the DNS tracking feature.<br>
- `FlowRTT`: enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
- `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
- `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
the kernel debug filesystem, so the eBPF pod has to run as privileged.
It requires using the OVN-Kubernetes network plugin with the Observability feature.
IMPORTANT: this feature is available as a Developer Preview.<br>
items:
description: |-
Agent feature, can be one of:<br>
- `PacketDrop`, to track packet drops.<br>
- `DNSTracking`, to track specific information on DNS traffic.<br>
- `FlowRTT`, to track TCP latency.<br>
- `NetworkEvents`, to track Network events.<br>
- `NetworkEvents`, to track Network events [Developer Preview].<br>
enum:
- PacketDrop
- DNSTracking
Expand Down Expand Up @@ -4122,8 +4124,8 @@ spec:
type: boolean
ovnKubernetes:
description: '`ovnKubernetes` defines the settings of the
OVN-Kubernetes CNI, when available. This configuration is
used when using OVN''s IPFIX exports, without OpenShift.
OVN-Kubernetes network plugin, when available. This configuration
is used when using OVN''s IPFIX exports, without OpenShift.
When using OpenShift, refer to the `clusterNetworkOperator`
property instead.'
properties:
Expand Down
8 changes: 5 additions & 3 deletions config/crd/bases/flows.netobserv.io_flowcollectors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3442,15 +3442,17 @@ spec:
If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
- `DNSTracking`: enable the DNS tracking feature.<br>
- `FlowRTT`: enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
- `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
- `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
the kernel debug filesystem, so the eBPF pod has to run as privileged.
It requires using the OVN-Kubernetes network plugin with the Observability feature.
IMPORTANT: this feature is available as a Developer Preview.<br>
items:
description: |-
Agent feature, can be one of:<br>
- `PacketDrop`, to track packet drops.<br>
- `DNSTracking`, to track specific information on DNS traffic.<br>
- `FlowRTT`, to track TCP latency.<br>
- `NetworkEvents`, to track Network events.<br>
- `NetworkEvents`, to track Network events [Developer Preview].<br>
enum:
- PacketDrop
- DNSTracking
Expand Down Expand Up @@ -3799,7 +3801,7 @@ spec:
When it is set to `true`, the value of `sampling` is ignored.
type: boolean
ovnKubernetes:
description: '`ovnKubernetes` defines the settings of the OVN-Kubernetes CNI, when available. This configuration is used when using OVN''s IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.'
description: '`ovnKubernetes` defines the settings of the OVN-Kubernetes network plugin, when available. This configuration is used when using OVN''s IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.'
properties:
containerName:
default: ovnkube-node
Expand Down
10 changes: 6 additions & 4 deletions docs/FlowCollector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5958,8 +5958,10 @@ the kernel debug filesystem, so the eBPF pod has to run as privileged.
If the `spec.agent.ebpf.privileged` parameter is not set, an error is reported.<br>
- `DNSTracking`: enable the DNS tracking feature.<br>
- `FlowRTT`: enable flow latency (sRTT) extraction in the eBPF agent from TCP traffic.<br>
- `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
the kernel debug filesystem, so the eBPF pod has to run as privileged.<br/>
- `NetworkEvents`: enable the Network events monitoring feature. This feature requires mounting
the kernel debug filesystem, so the eBPF pod has to run as privileged.
It requires using the OVN-Kubernetes network plugin with the Observability feature.
IMPORTANT: this feature is available as a Developer Preview.<br><br/>
</td>
<td>false</td>
</tr><tr>
Expand Down Expand Up @@ -8368,7 +8370,7 @@ When it is set to `true`, the value of `sampling` is ignored.<br/>
<td><b><a href="#flowcollectorspecagentipfixovnkubernetes-1">ovnKubernetes</a></b></td>
<td>object</td>
<td>
`ovnKubernetes` defines the settings of the OVN-Kubernetes CNI, when available. This configuration is used when using OVN's IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.<br/>
`ovnKubernetes` defines the settings of the OVN-Kubernetes network plugin, when available. This configuration is used when using OVN's IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down Expand Up @@ -8423,7 +8425,7 @@ refer to `forceSampleAll`. Alternatively, you can use the eBPF Agent instead of



`ovnKubernetes` defines the settings of the OVN-Kubernetes CNI, when available. This configuration is used when using OVN's IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.
`ovnKubernetes` defines the settings of the OVN-Kubernetes network plugin, when available. This configuration is used when using OVN's IPFIX exports, without OpenShift. When using OpenShift, refer to the `clusterNetworkOperator` property instead.

<table>
<thead>
Expand Down
Loading