Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OTP authenticator support #149

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Add OTP authenticator support #149

wants to merge 8 commits into from

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jan 14, 2024

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@cbaker6
Copy link
Member Author

cbaker6 commented Jan 14, 2024

@dblythy I still needs to do a little work on this and test it, but let me know what you think. I won't be for sure without testing, but from parse-community/parse-server#8661 it looks like you might be sending authData.mfa?.pending (I see a check for it in spec/AuthenticationAdapters.spec.js) to the client and it's sent as an object. If this is true, it will break strongly typed SDKs. I might able to add a workaround via Cloud Code that will delete pending before sending the user back to the client. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant