Skip to content

Add Python 3.13 support #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: py3.13
Choose a base branch
from
Open

Conversation

wchistow
Copy link

@wchistow wchistow commented Mar 2, 2025

This PR adds rules for Python 3.13.

What's new

@wchistow wchistow requested a review from netromdk as a code owner March 2, 2025 11:54
@wchistow wchistow closed this Apr 23, 2025
Copy link
Owner

@netromdk netromdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! And very sorry for the slow reply.
I only saw one thing to change.


def test_flush_from_xml_etree_ElementTree_XMLPullParser(self):
self.assertOnlyIn((3, 13), self.detect("from xml.etree import ElementTree\n"
"ElementTree().XMLParser().flush()"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you meant XMLPullParser instead of XMLParser here.

@netromdk netromdk reopened this May 25, 2025
@netromdk
Copy link
Owner

netromdk commented May 25, 2025

And if you can make it merge into branch py3.13 instead of master.
I need to do a little more modding before merging to master.
Thanks!

@netromdk netromdk self-assigned this May 25, 2025
@wchistow wchistow changed the base branch from master to py3.13 May 25, 2025 17:30
@wchistow
Copy link
Author

wchistow commented May 27, 2025

I changed the target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants