Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not deprecate srv record #260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Dec 11, 2023

I find it kind of handy since it simplifies broker management via one central point.

I find it kind of handy since it simplifies broker management via one central point.
@lspgn
Copy link
Member

lspgn commented Dec 13, 2023

I think that creates a dependency on DNS and does not track well changes to it (or would create the assumption you just need to update the SRV for GoFlow2 to automatically send to the new brokers).
In Kube or with automation, this make the SRV redundant. This said I don't have plans to remove this code just yet.

@simPod
Copy link
Contributor Author

simPod commented Dec 13, 2023

I think that creates a dependency on DNS and does not track well changes to it (or would create the assumption you just need to update the SRV for GoFlow2 to automatically send to the new brokers).

I understand. Maybe adding a doc could help to battle such assumption. I usually use DNS in brokers list as well so having a dependency on it is not such an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants