fix: FABRID gRPC bugs #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, rename variable that shadows package name
7 tasks
jeltevanbommel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the
FabridInfostruct to be empty, e.g. when the Daemon supports FABRID, but the control service does not support FABRID. The checks for this were missing when looking for hops with detached FABRID maps. This commit adds the check. Additionally, a variable name that collides with thefabridpackage name has been renamed.Also fixes a bug where the modification of the snet.Path's metadata happens on a copy. The modification of the metadata is necessary to update the FABRID info field with fetched detached maps. In an older version the .copy() call on the metadata was removed, this slipped back in during a rebase.
To prevent further issues with grpc_fabrid, and considering it is one of the only files that does not have test cases, added test cases.
This change is