Extend syntax used in link() method of LinkGenerator #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to bool" This reverts commit d16847f.
Warning doesn't catch that {_} doesn't work either
…sed to LatteFactory::create()
- inteface Nette\Application\IRouter replaced by Nette\Routing\Router
…e() for persistent parameters. [Closes nette/nette#703][Closes nette/nette#703][Closes #69]" (possible BC break) This reverts commit cda17f4. See https://forum.nette.org/cs/35528-stejne-pojmenovany-parametr-akce-presenteru-a-persistentni-odlisne-chovani-v-nette-2-0-oproti-aktualnimu#p221742 BC break: Property must be nullable, ie: #[Persistent] public ?int $foo
Proposed changes make possible to use in LinkGenerator the same syntax as in presenter - links started with //: or :
|
Also discused in #255 Some tests would be nice - https://github.com/nette/application/blob/30d90f4fca1df8face66b6963308935319413bfd/tests/Routers/LinkGenerator.phpt Btw, whats the |
|
@mabar experimental link aliases I believe. https://forum.nette.org/en/36451-nette-application-3-2-aliases-for-links |
dg
force-pushed
the
master
branch
2 times, most recently
from
bbea2e4
to
db6b14f
Compare
|
In branch 3.2-dev the link generation in presenters and LinkGenerator is merged and the syntax is identical. |
dg
force-pushed
the
master
branch
4 times, most recently
from
bf86204
to
c91f90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes make possible to use in LinkGenerator the same syntax as in presenter - links started with //: or :
In the current version of LinkGenerator it is not possible to use for $destination in method link() syntax :Module:Presenter:action or //:Module:Presenter:action as in presenter.
The proposed changes make possible to use this syntax in LinkGenerator also, withou any BC break, because the current syntax Module:Presenter:action will remain in function.
The proposal is also discussed on Nette formu in this post: https://forum.nette.org/cs/36468-rfc-rozsirit-syntaxi-parametru-destination-v-metode-linkgenerator-link#p226631