-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Column Index Support #14
base: master
Are you sure you want to change the base?
Conversation
Hey @darnfish let's stick with PRs for now :) |
src/typescript.ts
Outdated
@@ -1,6 +1,7 @@ | |||
import camelcase from 'camelcase' | |||
|
|||
export interface Column { | |||
position: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about we call this index
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :~)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some unit tests before shipping?
This PR adds support for respecting the column position when converting to TypeScript :~)
(cc @nettofarah, since I'm a collaborator now I'm not sure if I should push to master or make PRs for this kind of thing! Please lmk)