Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Column Index Support #14

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Column Index Support #14

wants to merge 6 commits into from

Conversation

darnfish
Copy link
Collaborator

@darnfish darnfish commented Sep 8, 2021

This PR adds support for respecting the column position when converting to TypeScript :~)

(cc @nettofarah, since I'm a collaborator now I'm not sure if I should push to master or make PRs for this kind of thing! Please lmk)

@darnfish darnfish requested a review from nettofarah September 8, 2021 18:04
@nettofarah
Copy link
Owner

Hey @darnfish let's stick with PRs for now :)
feel free to open them and I'll review

@@ -1,6 +1,7 @@
import camelcase from 'camelcase'

export interface Column {
position: number
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we call this index?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :~)

@nettofarah nettofarah changed the title Add Position Support Add Column Index Support Sep 8, 2021
Copy link
Owner

@nettofarah nettofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some unit tests before shipping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants