SSL_CVERIFY_REQUIRED to follow API docs #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
force-pushed
the
ssl_verify_required
branch
from
fc8a708
to
bce3d90
Compare
Motivation: The OpenSSL docs specify that the `SSL_VERIFY_FAIL_IF_NO_PEER_CERT` flag must be masked with `SSL_VERIFY_PEER`. Currently netty hard codes a value of `2` for required which is just the value of `SSL_VERIFY_FAIL_IF_NO_PEER_CERT`. [1] https://www.openssl.org/docs/man1.0.2/man3/SSL_CTX_set_verify.html > Server mode: if the client did not return a certificate, the TLS/SSL handshake is immediately terminated with a "handshake failure" alert. This flag must be used together with SSL_VERIFY_PEER.
Scottmitch
force-pushed
the
ssl_verify_required
branch
from
bce3d90
to
0f2b16d
Compare
|
nvm we are translating the values correctly under the covers: https://github.com/netty/netty-tcnative/blob/main/openssl-dynamic/src/main/c/sslutils.c#L642-L666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The OpenSSL docs specify that the
SSL_VERIFY_FAIL_IF_NO_PEER_CERTflag must be masked withSSL_VERIFY_PEER. Currently netty hard codes a value of2for required which is just the value ofSSL_VERIFY_FAIL_IF_NO_PEER_CERT.[1] https://www.openssl.org/docs/man1.0.2/man3/SSL_CTX_set_verify.html