Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Init #49

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: Init #49

merged 1 commit into from
May 23, 2024

Conversation

mightymax
Copy link
Collaborator

@mightymax mightymax commented May 23, 2024

  • the -- (double dash) argument should not be used in the described use-case.
  • the init script should only test for specific pipelines/configuration/example folder, not for pipelines
  • if "static" is excluded from the NPM package (like it was in .npmignore), the example pipeline can not be installed with --init, since it is not present

Fix #48

- the `--` argument should not be used in the described use-case.
- the init script should only test for specific "pipelines/configuration/example" folder, not for "pipelines"
- if "static" is excluded from the NPM package (in .npmignore), the example pipeline can of course not be installed with --init, since it is not present.
@ddeboer ddeboer changed the title Fixes issue #48 Fix init May 23, 2024
@ddeboer ddeboer changed the title Fix init fix: Init May 23, 2024
@ddeboer ddeboer merged commit 92f9b0b into main May 23, 2024
2 checks passed
@ddeboer ddeboer deleted the issues/48 branch May 23, 2024 10:43
Copy link

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation instructions incorrect
2 participants