Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sort GeoNames by relevance score #1066

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

ddeboer
Copy link
Member

@ddeboer ddeboer commented Aug 8, 2023

Ref #1064
Replace #1065

@ddeboer ddeboer force-pushed the 1064-geonames-score branch from 8acbc17 to 62fa189 Compare August 8, 2023 18:58
@ddeboer ddeboer merged commit b2cd5dc into master Aug 8, 2023
@ddeboer ddeboer deleted the 1064-geonames-score branch August 8, 2023 19:28
@ddeboer
Copy link
Member Author

ddeboer commented Aug 8, 2023

🎉 This PR is included in version 6.27.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member Author

ddeboer commented Aug 8, 2023

🎉 This PR is included in version 2.9.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@wmelder
Copy link
Contributor

wmelder commented Aug 9, 2023

Question: you're using vrank:simpleRank on an instance of a skos:Concept. The formal definition of the property describes it should be an owl:Thing as the domain:

vrank:simpleRank a rdf:Property, owl:DatatypeProperty, owl:FunctionalProperty;
    owl:propertyChainAxiom (vrank:hasRank vrank:rankValue) ;
    rdfs:label "rank";
    rdfs:comment "Directly connects owl:Thing with ranking values.";
    rdfs:domain owl:Thing;
    rdfs:range xsd:float .

How are we allowed to still use it?

@ddeboer
Copy link
Member Author

ddeboer commented Aug 10, 2023

Good question. As far as I can see, owl:Thing represents the set of all individuals, making all user-defined owl:Classes, including skos:Concept, subclasses of owl:Thing. The domain owl:Thing then includes skos:Concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants