Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: short descriptions of the terminology sources #645

Merged
merged 8 commits into from
Jun 2, 2022

Conversation

sdevalk
Copy link
Contributor

@sdevalk sdevalk commented May 12, 2022

Fix for #557.

This PR introduces short descriptions for the sources. The descriptions have been taken from the websites of the sources (if available) and then redacted a bit: not all original descriptions are usable for the NoT (i.e. concise and to the point).

@sdevalk
Copy link
Contributor Author

sdevalk commented May 12, 2022

@ddeboer Could you have a look? Would these descriptions be usable?

@sdevalk sdevalk requested a review from ddeboer May 12, 2022 11:19
@ddeboer
Copy link
Member

ddeboer commented May 12, 2022

We may also want to require schema:description in the SCHACL.

@sdevalk
Copy link
Contributor Author

sdevalk commented May 13, 2022

We may also want to require schema:description in the SCHACL.

@ddeboer Excellent! Done.

@sdevalk sdevalk merged commit 78c69f1 into master Jun 2, 2022
@sdevalk sdevalk deleted the feat-source-descriptions branch June 2, 2022 07:44
@ddeboer
Copy link
Member

ddeboer commented Jun 2, 2022

🎉 This PR is included in version 6.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@ddeboer
Copy link
Member

ddeboer commented Jun 24, 2022

🎉 This PR is included in version 2.2.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants