Use network "tcp" when calling tls.DialWithDialer #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
approved these changes
Aug 19, 2024
|
Just as a side note. While these changes worked for me when I submitted the PR, I haven't actually used/tested these changes since ~ October 2023. Assuming nothing has changed in "crypto/tls" the changes should still work though. |
|
Only DCO check has failed. Please have a look at how to fix it in the job description https://github.com/networkservicemesh/fanout/pull/56/checks?check_run_id=28971794785 |
Signed-off-by: Mika Dede <[email protected]>
Signed-off-by: Mika Dede <[email protected]>
|
Should work now. Forgot to Sign-Off first commit. |
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Set network to "tcp" instead "tcp-tls". This correctly connects to DoT servers.
Also renamed constant
tcptlctotcptlsunder the assumption that this is a typo. If there's a reason for this name let me know.