[TASK] Use TYPO3 HTTP configuration in sentry client #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With version 4 of the Sentry SDK, Sentry now ships a simple and custom HTTP client which is based on curl. Using Guzzle as HTTP client does not seem possible, since Sentry SDK does use `php-http/discovery` anymore. Basic HTTP configuration in $GLOBALS['TYPO3_CONF_VARS']['HTTP'] should be reflected to the Sentry HTTP client. This change reflects the following TYPO3 HTTP options to the Sentry HTTP client: * verify * http_timeout * connect_timeout Closes networkteam#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version 4 of the Sentry SDK, Sentry now ships a simple and custom HTTP client which is based on curl. Using Guzzle as HTTP client does not seem possible, since Sentry SDK does use
php-http/discoveryanymore.Basic HTTP configuration in $GLOBALS['TYPO3_CONF_VARS']['HTTP'] should be reflected to the Sentry HTTP client.
This change reflects the following TYPO3 HTTP options to the Sentry HTTP client:
verifyhttp_timeoutconnect_timeoutCloses #103