Parser for Apple peering notifications #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyngshede
requested review from
chadell,
glennmatthews,
pke11y,
scetron and
jvanderaa
as code owners
chadell
reviewed
May 3, 2023
| m = re.search(pattern, text) | ||
| return [CircuitImpact( | ||
| circuit_id=f'AS{m.group(1)}', | ||
| impact=Impact.NO_IMPACT)] |
There was a problem hiding this comment.
I guess you would like to mark the circuit state during the maintenance as OUTAGE? NO_IMPACT is supposed for a circuit that it's not being affected during the maintenance period
|
@slyngshede |
|
Yes, sorry, I got distracted. Apple apparently also have different time formats for different parts of the world, so I need to update the patch anyway. |
|
Hi @slyngshede , there is still some linting problem. anything we can help you with? |
|
@chadell No, I got it working, just been busy with other project :-) |
|
@slyngshede , if you can't finish it, I could do it for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser for Apple peering notification emails. We haven't yet seen anything that can be classified as other than "CONFIRMED"
The EmailSubjectParser behaves slightly different than one would expect based on the naming, in that it just get the entire email text, without line break. I would expect that it would receive ONLY the subject line, but that doesn't seem to be the case. Am I using it wrong perhaps?