Statements inside ROS_ASSERT_MSG are not run in release mode #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #80 |
|
@calum-blair-archangel Thanks for taking this on. We only merge from dev into master. Can you please rebase this pull request to merge into dev. |
When compiling in release mode (catkin_make -DCMAKE_BUILD_TYPE=Release), several ROS_ASSERT_MSG statements are not executed. This causes initialisation to fail and the relevant messages are not displayed. Move statements which set variables outside of the ROS_ASSERT_MSG statements.
ghost
changed the base branch from
|
@vik748 thanks, I've updated the branch and rebased |
mithundiddi
approved these changes
Sep 21, 2021
- adds missing ; on line 378 - fixes warning of printing var of size_t at two places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling in release mode (
catkin_make -DCMAKE_BUILD_TYPE=Release),several
ROS_ASSERT_MSGstatements are not executed. This causes camera initialisation to failand the relevant messages are not displayed. This PR moves statements which set variables
outside of the
ROS_ASSERT_MSGstatements.