Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in spinnaker 2.x.x which causes serial number to be read in… #84

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 28, 2020

… hex
Fixes #76

@ghost ghost requested a review from mithundiddi April 28, 2020 01:20
@ghost ghost mentioned this pull request Apr 28, 2020
@mithundiddi mithundiddi merged commit 96bc9ed into dev Apr 28, 2020
@mithundiddi mithundiddi deleted the cam_serial_number_bug branch April 28, 2020 01:42
@mithundiddi
Copy link
Member

I tested it with 1.13.0.31, works.
@abhishekbajpayee did you test with spinnaker sdk 2.x.x ?
thanks

@ghost ghost mentioned this pull request May 12, 2020
@soulslicer
Copy link

I tested it with 1.13.0.31, works.
@abhishekbajpayee did you test with spinnaker sdk 2.x.x ?
thanks

Not working

@abhishekbajpayee
Copy link
Contributor

@mithunvarma did you guys recently port this code over to Github? Just wondering how this shows I pushed a commit 18 days back :-)

@ghost
Copy link
Author

ghost commented May 15, 2020

@abhishekbajpayee I pushed a commit from the server on the car and it had your details saved on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants