Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search systems by dataset name #529

Merged
merged 2 commits into from
Nov 27, 2022
Merged

search systems by dataset name #529

merged 2 commits into from
Nov 27, 2022

Conversation

qjiang002
Copy link
Collaborator

This is a sub-component of PR #518

Search systems by dataset name

  • The dataset filter is added to the table header. This is a custom filter, a searchable select list. Without search text, it will display some dataset names. With search text, the dataset list will be updated.
  • It supports updating and reading from the url.

Screen Shot 2022-11-22 at 1 07 12 AM

Screen Shot 2022-11-22 at 1 07 46 AM

Screen Shot 2022-11-22 at 1 08 04 AM

@qjiang002 qjiang002 requested a review from pfliu-nlp November 22, 2022 06:16
@qjiang002 qjiang002 mentioned this pull request Nov 22, 2022
Closed
lyuyangh
lyuyangh approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@lyuyangh lyuyangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks!

frontend/src/components/SystemsTable/SystemTableContent.tsx Outdated
}, [datasetSearchText, filterValue.task]);

const onDatasetSearch = (value: string) => {
console.log("search:", value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this?

@qjiang002 qjiang002 merged commit 57a4adc into main Nov 27, 2022
@qjiang002 qjiang002 deleted the add-dataset-search-bar branch November 27, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuyangh lyuyangh lyuyangh approved these changes

@neubig neubig neubig approved these changes

@pfliu-nlp pfliu-nlp Awaiting requested review from pfliu-nlp pfliu-nlp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qjiang002 @neubig @lyuyangh