Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sorted column of system table #530

Merged
merged 3 commits into from
Nov 27, 2022
Merged

fix sorted column of system table #530

merged 3 commits into from
Nov 27, 2022

Conversation

qjiang002
Copy link
Collaborator

This is a sub-component of PR #518

Fix the sorted column of System table

  • The sorter selector is kept separately above the table, and the sorted column in the table is fixed to the left and the column header sorter is set to be the same as the sorting direction.
  • In the sorter selector, 'Created At' is changed to 'Sorted by' for easier understanding.

Screen Shot 2022-11-22 at 3 15 27 PM

Copy link
Member

@lyuyangh lyuyangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall, looks great!

Do you think we should also pin "Created At" if it is the sort column? Also, I agree that "Sort By" makes it clear what that selector does in the default view. But when a user wants to change the sort column from something else to "Created At" (sort by time), the label may become confusing. Now that we have moved several selectors to the table, could we maybe show "Sort By" as a prompt next to the selector but still use "Created At" as the label for that "sort by time" option?

@qjiang002
Copy link
Collaborator Author

Thanks @lyuyangh for the suggestion. I add a prefix box before the selector, and pin Created_At to the right because it is a default and less important sorted column compared with those metric columns.

Screen Shot 2022-11-27 at 1 12 33 PM

Copy link
Member

@lyuyangh lyuyangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qjiang002 qjiang002 merged commit 9a2c9ae into main Nov 27, 2022
@qjiang002 qjiang002 deleted the pin-sorted-column branch November 27, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants