Composability #219
Open
Composability #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsikka
requested changes
Dec 2, 2024
src/compressed_tensors/compressors/model_compressors/model_compressor.py
Show resolved
Hide resolved
| load_pretrained_quantization(model, model_path) | ||
| model_path_or_state_dict = ( | ||
| model.state_dict() if sparse_decompressed else model_path | ||
| ) |
There was a problem hiding this comment.
why did we remove load_pretrained_quantization? what happens when there's only quantization?
There was a problem hiding this comment.
theres duplicate
if self.quantization_compressor is not None:
There was a problem hiding this comment.
The duplicate condition above is needed to update the structure of the model for now, Will update in a follow up to completely isolate these two compressions.
@dsikka load_pretrained_quantization this call is in the above if condition, it works for just quantized cases as well.
There was a problem hiding this comment.
Remove the unnecessary apply_quantization_config call
| # update model structure | ||
| names_to_scheme = apply_quantization_config(model, self.quantization_config) | ||
| load_pretrained_quantization(model, model_path) | ||
|
|
There was a problem hiding this comment.
Should only be applying the quant compressor once
horheynm
reviewed
Dec 2, 2024
rahul-tuli
force-pushed
the
composability
branch
from
49cc3d8 to
609a3c3
Compare
horheynm
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.