Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handling empty sparsity config #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Jan 14, 2025

FIX vllm-project#12044

This PR fixes a bug where the sparsity_config in the CompressedTensorsConfig class would not handle empty configurations correctly. The issue, tracked in vllm-project#12044, arose due to the explicit check for None values instead of evaluating the truthiness of sparsity_config. The fix ensures that empty configurations are now handled gracefully by directly checking the truthiness of sparsity_config.

Changes

  • Updated the conditional check in CompressedTensorsConfig.get_sparsity_config to evaluate the truthiness of sparsity_config instead of explicitly comparing against None.

Testing

The fix was tested by running the following:

  • nm-testing/llama2.c-stories42M-quantized-fp8-Dynamic
    • This test case includes an empty sparsity_config and confirmed the correctness of the fix.

Resolves

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@rahul-tuli rahul-tuli force-pushed the fix-empty-sparsity-config branch from 5e81733 to 6e098fe Compare January 14, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ValidationError when loading fp8-dynamic model with empty "sparsity_config"
1 participant