Fix: Handling empty sparsity config #54
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX vllm-project#12044
This PR fixes a bug where the
sparsity_config
in theCompressedTensorsConfig
class would not handle empty configurations correctly. The issue, tracked in vllm-project#12044, arose due to the explicit check forNone
values instead of evaluating the truthiness ofsparsity_config
. The fix ensures that empty configurations are now handled gracefully by directly checking the truthiness ofsparsity_config
.Changes
CompressedTensorsConfig.get_sparsity_config
to evaluate the truthiness ofsparsity_config
instead of explicitly comparing againstNone
.Testing
The fix was tested by running the following:
nm-testing/llama2.c-stories42M-quantized-fp8-Dynamic
sparsity_config
and confirmed the correctness of the fix.Resolves