-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the memory allocation for rxd reactions to register_rate
.
#2631
base: master
Are you sure you want to change the base?
Conversation
✔️ cffca52 -> Azure artifacts URL |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
- Coverage 66.30% 66.28% -0.02%
==========================================
Files 558 558
Lines 108424 108393 -31
==========================================
- Hits 71887 71846 -41
- Misses 36537 36547 +10 ☔ View full report in Codecov by Sentry. |
cffca52
to
e7f15e5
Compare
✔️ e7f15e5 -> Azure artifacts URL |
✔️ 7f4c46b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
@alkino: maybe you can help here to make Sonar check happy? |
Except if we want to change everything to use smart pointers instead of this huge structure of mallocs. We should go with this bad sonar review. |
Ok. |
This comment has been minimized.
This comment has been minimized.
Quality Gate failedFailed conditions B Maintainability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
✔️ a93e7e3 -> Azure artifacts URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should resolve #2622