Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodelist support different regions #2780

Merged
merged 18 commits into from
May 8, 2024
Merged

Conversation

rgourdine
Copy link
Collaborator

Closes #1280

@rgourdine rgourdine requested a review from ramcdougal March 15, 2024 19:42
Copy link

✔️ f7cc0ec -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ dc0a240 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 4767eb7 -> Azure artifacts URL

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (cb09926) to head (d62fc05).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2780      +/-   ##
==========================================
- Coverage   67.20%   67.20%   -0.01%     
==========================================
  Files         563      563              
  Lines      104244   104253       +9     
==========================================
+ Hits        70054    70060       +6     
- Misses      34190    34193       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@alkino alkino added the rxd reaction-diffusion label Apr 9, 2024
@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 809bfed -> Azure artifacts URL

Copy link

✔️ e8fb046 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ d72e71c -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ b092871 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ c9468c8 -> Azure artifacts URL

Copy link
Member

@ramcdougal ramcdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add to the public API... Please precede the new function babe with an underscore.

Copy link

✔️ 84876f4 -> Azure artifacts URL

Copy link
Member

@ramcdougal ramcdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbpbuildbot

This comment has been minimized.

Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ d62fc05 -> Azure artifacts URL

@pramodk pramodk merged commit 2b040b7 into master May 8, 2024
37 checks passed
@pramodk pramodk deleted the nodelist_support_different_regions branch May 8, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve NodeList support for different region types
5 participants