Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept same argument for nrnivmod-core and nrnivmodl #2891

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alkino
Copy link
Member

@alkino alkino commented May 31, 2024

No description provided.

@alkino alkino linked an issue May 31, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current NEURON specific part of nrnivmodl isn't above criticism, but I wonder if it would not be best to adopt its file handling part for -coreneuron. I.e. it leaves mod files in place, allows spaces in path names, and allows multiple directory paths and specific full paths for mod files. The benefit is that in-situ mod files may have position dependent references to other .h and .inc files. It nevertheless generates cpp, .o files, and library in the 'x86_64' folder mostly because of the generated makemod2c_inc file that is included by the nrnmech_makefile

@pramodk
Copy link
Member

pramodk commented Jun 17, 2024

IIRC, we discussed above comment with Michael and we decided to keep that aside.

@alkino: I guess we would like to get current changes merged, right? In that case, could you see the failing CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nrnivmodl-core does not accept individual mod files as input
4 participants