-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install ONE requirements file with all requirements. #2955
Conversation
When installing NMODL requirements after the fixed numpy version, NMODLs lesser constrained dependencies take precedence over the currently installed packages. This PR: * Will consider only the build dependencies of NMODL * Construct one requirements file with the merged requirements of NMODL, NEURON
Will it fix
? |
Can do by adding |
Actually So the error may occur even more frequently if we don't cache... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2955 +/- ##
==========================================
- Coverage 67.25% 67.25% -0.01%
==========================================
Files 571 571
Lines 104902 104902
==========================================
- Hits 70557 70550 -7
- Misses 34345 34352 +7 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
✔️ 233d970 -> Azure artifacts URL |
Quality Gate passedIssues Measures |
✔️ 470a4bc -> Azure artifacts URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For reference, I am about 99% sure it's this issue: pypa/pip#11153 |
When installing NMODL requirements after the fixed numpy version,
NMODLs lesser constrained dependencies take precedence over the
currently installed packages.
This PR:
NMODL, NEURON
setuptools
requirement for Python 3.12 and Windows that broke with a newer version