-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CellBuild topology page easily crashes when deleting sections with continuous create on #3005
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3005 +/- ##
==========================================
+ Coverage 67.26% 67.35% +0.09%
==========================================
Files 573 573
Lines 104927 104936 +9
==========================================
+ Hits 70576 70684 +108
+ Misses 34351 34252 -99 ☔ View full report in Codecov by Sentry. |
✔️ eb5a542 -> Azure artifacts URL |
The CI documentation error is
I presume this will go away after a near future merge from master. There is CI ubuntu error
I'm not familiar with the diagnostic process in this area. My presumption is that it is not related to this PR. |
✔️ 6321177 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
@pramodk |
I just noticed a comment by @1uc at |
Yes, this is the same issue. The pipeline that fails is called Rerunning should make CI go green again. |
✔️ 0b8fc13 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ d6ac77e -> Azure artifacts URL |
✔️ 34c8339 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✔️ a8f7566 -> Azure artifacts URL |
I have retriggered blueconfig CI. Hopefully, that will be green. As this is reviewed/discussed, feel free to merge once gitlab will done. |
✔️ d7d465c -> Azure artifacts URL |
✔️ 53b87f7 -> Azure artifacts URL |
@pramodk Can you review? It's ready to merge as far as I can see. |
Quality Gate passedIssues Measures |
✔️ 436c87c -> Azure artifacts URL |
At the last NEURON course, some users experienced issues with deleting sections in cell builder with continuous create on.
With this PR, the topology page now seems robust for all operations with continuous create.
There are likely some accumulating memory leaks during CellBuild usage and left over subsidiary objects when a CellBuild is closed. Those should be cleaned up in a separate pr.
The test_secref.py covers 97% of secref.cpp
When this PR is merged, it should be cherry picked into release/8.2