-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper for parsing tuples using nanobind #3025
base: master
Are you sure you want to change the base?
Conversation
4e5864d
to
72584bc
Compare
✔️ 72584bc -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3025 +/- ##
==========================================
- Coverage 67.27% 67.27% -0.01%
==========================================
Files 572 573 +1
Lines 104944 104944
==========================================
- Hits 70605 70597 -8
- Misses 34339 34347 +8 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvements, w.r.t. naming/error messages would be nice. Other than that I think it'll provide a useful building block for modernizing a particular pattern found frequently in our code.
This comment has been minimized.
This comment has been minimized.
2bfe2e2
to
8ab8a6c
Compare
* This can also be used for parsing `args`
8ab8a6c
to
63e575a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✔️ 63e575a -> Azure artifacts URL |
Quality Gate passedIssues Measures |
✔️ 738ff1c -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
@alkino / @1uc I seem to be getting errors with nanobind not being available: I'm confused as to why the tests are "automatically" including nanobind: My plan to deal with it is to only include the |
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
✔️ 0df381e -> Azure artifacts URL |
args