Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanobind: use loads and dumps as callable #3043

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Conversation

alkino
Copy link
Member

@alkino alkino commented Aug 14, 2024

No description provided.

Copy link

✔️ a9597fc -> Azure artifacts URL

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.27%. Comparing base (09d0490) to head (54771d3).
Report is 2 commits behind head on master.

Files Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3043      +/-   ##
==========================================
- Coverage   67.28%   67.27%   -0.02%     
==========================================
  Files         571      571              
  Lines      104913   104885      -28     
==========================================
- Hits        70588    70558      -30     
- Misses      34325    34327       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link

Copy link

✔️ 54771d3 -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: launching for 54771d3 via its drop url

Copy link
Contributor

NEURON ModelDB CI: 54771d3 -> download reports from here

@alkino
Copy link
Member Author

alkino commented Aug 15, 2024

neuron-modeldb-ci is 🟢

@alkino alkino requested a review from ferdonline August 15, 2024 11:45
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work :)

@alkino alkino merged commit c918f6b into master Aug 15, 2024
41 checks passed
@alkino alkino deleted the cornu/nanobind_loads_dumps branch August 15, 2024 12:07
mgeplf pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants