Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for KSChan channel __doc__ string with ModelView. #3075

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

nrnhines
Copy link
Member

Closes #2370

@nrnhines nrnhines requested a review from ramcdougal September 10, 2024 12:21
Copy link

✔️ 08bf24f -> Azure artifacts URL

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.27%. Comparing base (1d812c8) to head (08bf24f).

Files with missing lines Patch % Lines
share/lib/python/neuron/__init__.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3075      +/-   ##
==========================================
- Coverage   67.27%   67.27%   -0.01%     
==========================================
  Files         571      571              
  Lines      104870   104868       -2     
==========================================
- Hits        70556    70551       -5     
- Misses      34314    34317       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ f83104d -> Azure artifacts URL

@nrnhines nrnhines requested a review from alkino September 17, 2024 14:26
Copy link

Copy link

✔️ 197b731 -> Azure artifacts URL

@nrnhines nrnhines merged commit 4d749f1 into master Sep 17, 2024
35 of 36 checks passed
@nrnhines nrnhines deleted the hines/mviewfix branch September 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelView crashes with channel builder models, e.g. 152028
3 participants