Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments for nrnpy_pyCallObject are created with nanobind #3140

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Oct 21, 2024

No description provided.

Copy link

✔️ 07a6f0c -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ b9f5af1 -> Azure artifacts URL

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.18%. Comparing base (ceedb15) to head (4819f04).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3140      +/-   ##
==========================================
- Coverage   67.19%   67.18%   -0.01%     
==========================================
  Files         572      572              
  Lines      111394   111399       +5     
==========================================
- Hits        74849    74846       -3     
- Misses      36545    36553       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@alkino alkino requested review from ferdonline and 1uc October 21, 2024 18:10
1uc
1uc previously approved these changes Oct 22, 2024
src/nrnpython/nrnpy_p2h.cpp Outdated Show resolved Hide resolved
@1uc 1uc dismissed their stale review October 22, 2024 14:53

wrong button

Copy link

Copy link

✔️ 4819f04 -> Azure artifacts URL

@alkino alkino enabled auto-merge (squash) October 24, 2024 08:23
@alkino alkino merged commit 13e183b into master Oct 24, 2024
37 checks passed
@alkino alkino deleted the nanobind_arguments branch October 24, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants