Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ACG by Random123 #3190

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Replace ACG by Random123 #3190

merged 3 commits into from
Nov 11, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 9, 2024

The last one.

@alkino alkino requested a review from nrnhines November 9, 2024 14:57
Copy link

✔️ 0678ba4 -> Azure artifacts URL

Copy link

sonarqubecloud bot commented Nov 9, 2024

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (625f3d1) to head (75aafb5).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3190   +/-   ##
=======================================
  Coverage   67.06%   67.07%           
=======================================
  Files         570      569    -1     
  Lines      111232   111204   -28     
=======================================
- Hits        74599    74590    -9     
+ Misses      36633    36614   -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ 75aafb5 -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: launching for 75aafb5 via its drop url

@alkino
Copy link
Member Author

alkino commented Nov 11, 2024

There is differences in nrn-modeldb that we shoud analyze.

@nrnhines
Copy link
Member

nrnhines commented Nov 11, 2024

There is differences in nrn-modeldb that we shoud analyze.

I agree. It's a bit time consuming and I have little doubt it's due to different random values. But it should be checked. I will do that.

I verified that the differences for the 15 models were due to the change in default randomness. Model 18502 was particularly different but was still due to randomness and much more similar results for the graphs were obtained with
Random123_globalindex(1)

@nrnhines nrnhines merged commit 095d858 into master Nov 11, 2024
38 of 39 checks passed
@nrnhines nrnhines deleted the cornu/acg branch November 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants