Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nanobind to simplify functions gui{get,set} #3217

Merged
merged 23 commits into from
Nov 21, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 17, 2024

No description provided.

@alkino alkino force-pushed the cornu/nanobind/guiget_set branch from ed3601a to 2921d1d Compare November 17, 2024 09:10
@alkino alkino changed the base branch from 1uc/modernize-decref-6 to 1uc/modernize-decref-3 November 17, 2024 09:15
Copy link

✔️ 5fb3293 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Base automatically changed from 1uc/modernize-decref-3 to master November 18, 2024 07:28
@alkino alkino marked this pull request as ready for review November 18, 2024 08:28
@alkino alkino force-pushed the cornu/nanobind/guiget_set branch from 8182df8 to ff8bd9b Compare November 18, 2024 08:42
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (7f38f75) to head (9daaf08).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 0.00% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3217   +/-   ##
=======================================
  Coverage   67.07%   67.08%           
=======================================
  Files         569      569           
  Lines      111141   111131   -10     
=======================================
  Hits        74549    74549           
+ Misses      36592    36582   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

✔️ ff8bd9b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

src/nrnpython/nrnpy_p2h.cpp Outdated Show resolved Hide resolved
1uc
1uc previously approved these changes Nov 18, 2024
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes, this looks correct.

@alkino alkino enabled auto-merge (squash) November 18, 2024 14:32
@bbpbuildbot

This comment has been minimized.

@1uc 1uc dismissed their stale review November 21, 2024 08:10

CI didn't pass.

Copy link

Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI agrees with us: nice work.

Copy link

✔️ 9daaf08 -> Azure artifacts URL

@alkino alkino merged commit c19c884 into master Nov 21, 2024
35 checks passed
@alkino alkino deleted the cornu/nanobind/guiget_set branch November 21, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants