-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nanobind to simplify functions gui{get,set} #3217
Conversation
Documentation for PyObject_SetItem clearly states that it doesn't steal `pn`. The other call is undocumented.
ed3601a
to
2921d1d
Compare
✔️ 5fb3293 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
8182df8
to
ff8bd9b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3217 +/- ##
=======================================
Coverage 67.07% 67.08%
=======================================
Files 569 569
Lines 111141 111131 -10
=======================================
Hits 74549 74549
+ Misses 36592 36582 -10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
✔️ ff8bd9b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI passes, this looks correct.
This comment has been minimized.
This comment has been minimized.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI agrees with us: nice work.
✔️ 9daaf08 -> Azure artifacts URL |
No description provided.