Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanobind: use more nb::dict #3250

Closed
wants to merge 2 commits into from
Closed

Nanobind: use more nb::dict #3250

wants to merge 2 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 26, 2024

No description provided.

@alkino alkino force-pushed the cornu/nb/more_dict branch from 440f023 to c01199d Compare November 26, 2024 09:58
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (bd89877) to head (ee6aa9d).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_hoc.cpp 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files         570      570              
  Lines      111066   111065       -1     
==========================================
- Hits        74502    74497       -5     
- Misses      36564    36568       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ c01199d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

Copy link

✔️ ee6aa9d -> Azure artifacts URL

@alkino alkino closed this Dec 10, 2024
@alkino alkino deleted the cornu/nb/more_dict branch December 10, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants