Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more set of RAII related modernizations. #3270

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 4, 2024

A set of changes I was working on before leaving BBP.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 80.32787% with 24 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (74dcdd5) to head (a7d777a).

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 54.83% 14 Missing ⚠️
src/nrnpython/nrnpy_hoc.cpp 88.00% 6 Missing ⚠️
src/nrnpython/nrnpy_nrn.cpp 92.50% 3 Missing ⚠️
src/neuron/unique_cstr.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3270      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files         571      571              
  Lines      111055   111045      -10     
==========================================
- Hits        74488    74479       -9     
+ Misses      36567    36566       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ fbfecb2 -> Azure artifacts URL

@1uc 1uc marked this pull request as ready for review December 6, 2024 11:10
Copy link

✔️ a7d777a -> Azure artifacts URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants