Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iterator #3275

Merged
merged 12 commits into from
Dec 10, 2024
Merged

Add iterator #3275

merged 12 commits into from
Dec 10, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Dec 6, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (00ba007) to head (4c76fc8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrniv/secbrows.cpp 0.00% 4 Missing ⚠️
src/nrnoc/solve.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3275   +/-   ##
=======================================
  Coverage   67.05%   67.06%           
=======================================
  Files         571      572    +1     
  Lines      111080   111073    -7     
=======================================
- Hits        74489    74488    -1     
+ Misses      36591    36585    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azure-pipelines Azure Pipelines
Copy link

✔️ 8bd14c0 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ c26ef21 -> Azure artifacts URL

@azure-pipelines Azure Pipelines
Copy link

✔️ e2f0a2e -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino marked this pull request as ready for review December 10, 2024 10:19
@azure-pipelines Azure Pipelines
Copy link

✔️ 6e8e1a4 -> Azure artifacts URL

JCGoran
JCGoran approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, only minor comments.

src/oc/list.cpp Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alkino alkino enabled auto-merge (squash) December 10, 2024 14:33
@azure-pipelines Azure Pipelines
Copy link

✔️ 4c76fc8 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #240220 (:no_entry:) have been uploaded here!

Status and direct links:

@alkino alkino merged commit baf9ea8 into master Dec 10, 2024
36 checks passed
@alkino alkino deleted the cornu/i_love_iterator branch December 10, 2024 15:40
@JCGoran JCGoran mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCGoran JCGoran JCGoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @JCGoran