Cleanup in ivocmain.cpp
#3297
Open
Cleanup in ivocmain.cpp
#3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCGoran
force-pushed
the
jelic/ivocmain_cleanup
branch
from
9d111ee to
42b438c
Compare
JCGoran
force-pushed
the
jelic/ivocmain_cleanup
branch
from
e019308 to
0f4f052
Compare
|
✔️ 78d8a9a -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3297 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 571 571
Lines 111055 111060 +5
=======================================
+ Hits 74487 74491 +4
- Misses 36568 36569 +1 ☔ View full report in Codecov by Sentry. |
matz-e
approved these changes
Dec 19, 2024
alkino
reviewed
Dec 21, 2024
src/ivoc/ivocmain.cpp
Outdated
| } | ||
| char buf[256]; | ||
| Sprintf(buf, | ||
| "Can't load NEURON resources from %s[aults]", |
There was a problem hiding this comment.
The block can be simplify with:
fmt::print("Can't load NEURON resources from {}[aults]\n", nrn_def_path1);
|
✔️ da6743e -> Azure artifacts URL |
JCGoran
commented
Dec 22, 2024
|
|
✔️ 8719b3a -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.