Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.md Update and Documentation Proposal #105
base: main
Are you sure you want to change the base?
README.md Update and Documentation Proposal #105
Changes from 10 commits
1e55d48
3415ebf
e178d46
feef84c
4078607
4ad390e
1bf799e
2f42a11
0607fc2
bc3120a
98c068d
4c93b8b
95d40cf
26ed943
e5aaec7
ba3f134
aa67c24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's way too specific. What if 15.0.2 comes out? Can I use it? likely so. I suggest another wording, be more general to other distros (see eg how we do it in SCT).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandrinebedard from your comments "2- Can you open the python console and screenshot the line where there is the error? (there should have some errors when a slicer module cannot be instantiated).
same thing again, here is the error in the python console:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? it should or it should not. This statement is confusing for the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so obvious how to clone a github page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out slicedCARD doesn't work if not installed in the root directory (tried to copy it on my desktop so I would suggest this new version. So I would definitely not put in the location of your choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Hm thats a problem. On my side, it is installed in the location of my choice (not on my desktop --- somewhere in documents etc.) Also, I would avoid the recomandation to use terminal: here, targeted audience includes non-technical staff (e.g. clinicians) for which the word 'terminal' sounds nothing... will keep the discussion open so we can discuss about this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe say download instead of cloning, cloning is also very technical, and say how to download, just linking to the repository doesn't help:
or link to a releas or dowload link: Download ZIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @sandrine . but how to link to the zip download as you did? also to keep the latest version always so no need to update very time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that discussion thread should go in a specific issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this part is not clear. I think some words are missing and the parentheses don't really help the understanding. I would go for something like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little typo: After that, (should have a comma)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxradx Thomas' suggestion is excellent-- accept and fix the typo so others can comment on the new modifications