Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] clean up #19

Merged
merged 9 commits into from
Feb 19, 2024
Merged

[MAINT] clean up #19

merged 9 commits into from
Feb 19, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 19, 2024

  • drop seaborn as dependency (not used by package but by examples)
  • make sure example and test outputs are saved in a single folder
  • clean up doc conf
  • update changelog
  • add type annotations
  • use rich for progress bar

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@6ab9d13). Click here to learn what that means.

Files Patch % Lines
neurodesign/classes.py 65.38% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   85.51%           
=========================================
  Files             ?        5           
  Lines             ?      842           
  Branches          ?        0           
=========================================
  Hits              ?      720           
  Misses            ?      122           
  Partials          ?        0           
Flag Coverage Δ
macos-latest_3.10 85.51% <70.00%> (?)
macos-latest_3.11 85.51% <70.00%> (?)
macos-latest_3.12 85.51% <70.00%> (?)
macos-latest_3.8 85.51% <70.00%> (?)
macos-latest_3.9 85.51% <70.00%> (?)
ubuntu-latest_3.10 85.51% <70.00%> (?)
ubuntu-latest_3.11 85.51% <70.00%> (?)
ubuntu-latest_3.12 85.51% <70.00%> (?)
ubuntu-latest_3.8 85.51% <70.00%> (?)
ubuntu-latest_3.9 85.51% <70.00%> (?)
windows-latest_3.10 85.47% <70.00%> (?)
windows-latest_3.11 85.47% <70.00%> (?)
windows-latest_3.12 85.47% <70.00%> (?)
windows-latest_3.8 85.47% <70.00%> (?)
windows-latest_3.9 85.47% <70.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 12af681 into neuropower:master Feb 19, 2024
23 checks passed
@Remi-Gau Remi-Gau deleted the clean branch February 19, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants