-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Use PyMARE for image-based meta-analyses #273
Conversation
# Conflicts: # nimare/meta/esma.py # nimare/meta/ibma.py
So far, the main blocker on this has been neurostuff/PyMARE#42, but a simple hack is to just mask out any voxels where any of the input maps has a value of exactly 0. I'm going to push that for now, even though it's a suboptimal solution. |
The IBMA tests are passing locally!!!! 🎉 But we are going to either need a fixed release for PyMARE or pin the dependency to GitHub. Also the outputs only grab FE stats, so if we really want the RE stats, that will need to be updated. I also haven't done anything as far as permutation tests of MCC of any kind. The standard NiMARE correctors (e.g., FDRCorrector) should work fine, but it's possible that we'll want some native correction methods implemented for the IBMA estimators (like how we have the |
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 72.97% 74.15% +1.18%
==========================================
Files 40 39 -1
Lines 3882 3711 -171
==========================================
- Hits 2833 2752 -81
+ Misses 1049 959 -90
Continue to review full report at Codecov.
|
Closes #211, closes #108.
Changes proposed in this pull request: