Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing circular dependency #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Kanai2003
Copy link

Resolve: #88

there is a circular dependency between src/ws/websocket.ts and src/api/extensions.ts

Circular dependency: src/ws/websocket.ts -> src/api/extensions.ts -> src/ws/websocket.ts

removing dependency from websocket.ts

Resolve: neutralinojs#88

there is a circular dependency between `src/ws/websocket.ts`
and `src/api/extensions.ts`

```
Circular dependency: src/ws/websocket.ts -> src/api/extensions.ts -> src/ws/websocket.ts

```
removing dependency from websocket.ts
@monsterkodi
Copy link

hello kanai,
your change fixes the first of the two mac build issues.
the second error is still there when i build a fresh checkout of your branch:

`npm run build

@neutralinojs/[email protected] build
node build.mjs

Preprocessing files...
import src/index.ts
generate dist/neutralino.mjs
generate lib
generate dist/neutralino.js
/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2082
isDefaultExport: specifier.name.text === "default",
^

TypeError: Cannot read properties of undefined (reading 'text')
at getExportedSymbolFromExportSpecifier (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2082:41)
at createExportSpecifierFromNameAndModifiers (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2103:29)
at visitInterfaceDeclaration$5 (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2445:32)
at visitNode$c (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2528:16)
at /Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2554:13
at visitNodes (/Users/kodi/Desktop/test/neutralino.js/node_modules/typescript/lib/typescript.js:31214:30)
at forEachChildInBlock (/Users/kodi/Desktop/test/neutralino.js/node_modules/typescript/lib/typescript.js:31921:16)
at Object.forEachChild (/Users/kodi/Desktop/test/neutralino.js/node_modules/typescript/lib/typescript.js:31988:47)
at Object.childContinuation (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2553:52)
at visitModuleDeclaration$8 (/Users/kodi/Desktop/test/neutralino.js/node_modules/rollup-plugin-ts/dist/cjs/index.js:2455:28) {
code: 'PLUGIN_ERROR',
plugin: 'Typescript',
hook: 'generateBundle'
}`

@monsterkodi
Copy link

it might be a bug in rollup-plugin-ts , i am not sure.

@Kanai2003
Copy link
Author

Thanks @monsterkodi for addressing the second problem, let me figure it out

@Kanai2003
Copy link
Author

@monsterkodi you are right. It seems like need to update rollup library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build not working on mac
2 participants